Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch to /usr/bin/time for measuring time + memory in physmon #3007

Merged
merged 10 commits into from Mar 7, 2024

Conversation

paulgessinger
Copy link
Member

I'm hoping this circumvents the problem of missing memory and time measurements. They're possibly less accurate, but less buggy for now. Should produce the same CSV as before, and I still use the custom python tool to convert them into a combined CSV that's published on the tracker.

@paulgessinger paulgessinger added this to the v33.0.0 milestone Mar 5, 2024
@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Plugins Affects one or more Plugins labels Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.68%. Comparing base (f25a727) to head (3005785).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3007   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files         493      493           
  Lines       29052    29052           
  Branches    13850    13850           
=======================================
  Hits        14143    14143           
  Misses       4965     4965           
  Partials     9944     9944           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the Component - Plugins Affects one or more Plugins label Mar 5, 2024
andiwand
andiwand previously approved these changes Mar 5, 2024
CI/physmon/phys_perf_mon.sh Outdated Show resolved Hide resolved
@paulgessinger paulgessinger modified the milestones: v33.0.0, next Mar 6, 2024
@kodiakhq kodiakhq bot merged commit d455e02 into acts-project:main Mar 7, 2024
54 checks passed
@github-actions github-actions bot removed the automerge label Mar 7, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Mar 7, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Mar 7, 2024
…cts-project#3007)

I'm hoping this circumvents the problem of missing memory and time measurements. They're possibly less accurate, but less buggy for now. Should produce the same CSV as before, and I still use the custom python tool to convert them into a combined CSV that's published on the tracker.
andiwand added a commit to andiwand/acts that referenced this pull request Mar 8, 2024
kodiakhq bot pushed a commit that referenced this pull request Mar 9, 2024
#3017)

Reverting #3007 as it seems to break the physmon exit code propagation
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Mar 11, 2024
dimitra97 pushed a commit to dimitra97/acts that referenced this pull request Mar 19, 2024
@paulgessinger paulgessinger modified the milestones: next, v33.1.0 Mar 26, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…cts-project#3007)

I'm hoping this circumvents the problem of missing memory and time measurements. They're possibly less accurate, but less buggy for now. Should produce the same CSV as before, and I still use the custom python tool to convert them into a combined CSV that's published on the tracker.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…cts-project#3007)

I'm hoping this circumvents the problem of missing memory and time measurements. They're possibly less accurate, but less buggy for now. Should produce the same CSV as before, and I still use the custom python tool to convert them into a combined CSV that's published on the tracker.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fails Athena tests This PR causes a failure in the Athena tests Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants