Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove AbstractVolume #3053

Merged
merged 2 commits into from
Mar 25, 2024
Merged

refactor: Remove AbstractVolume #3053

merged 2 commits into from
Mar 25, 2024

Conversation

paulgessinger
Copy link
Member

Re-adds the changes from #3030, that were reverted in the meantime.

@paulgessinger
refactor: Remove AbstractVolume
ed8e1ca 
Re-adds the changes from acts-project#3030, that were reverted in the meantime.
@paulgessinger paulgessinger added this to the next milestone Mar 25, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation labels Mar 25, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 48.81%. Comparing base (3eb0b4f) to head (d6e5e24).

Files Patch % Lines
Core/src/Geometry/DiscLayer.cpp 0.00% 0 Missing and 7 partials ⚠️
Core/src/Geometry/CylinderLayer.cpp 0.00% 0 Missing and 5 partials ⚠️
Core/src/Geometry/CylinderVolumeHelper.cpp 0.00% 0 Missing and 2 partials ⚠️
Core/src/Visualization/GeometryView3D.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3053      +/-   ##
==========================================
- Coverage   48.82%   48.81%   -0.01%     
==========================================
  Files         491      489       -2     
  Lines       28909    28883      -26     
  Branches    13724    13711      -13     
==========================================
- Hits        14114    14099      -15     
+ Misses       4956     4955       -1     
+ Partials     9839     9829      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 2da4383 into acts-project:main Mar 25, 2024
54 checks passed
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [2da4383]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Mar 25, 2024
@paulgessinger paulgessinger modified the milestones: next, v34.0.0 Mar 26, 2024
@andiwand andiwand removed the Breaks Athena build This PR breaks the Athena build label Apr 10, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@paulgessinger @EleniXoch
refactor: Remove AbstractVolume (acts-project#3053)
52ff315 
Re-adds the changes from acts-project#3030, that were reverted in the meantime.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@paulgessinger @asalzburger
refactor: Remove AbstractVolume (acts-project#3053)
fa33270 
Re-adds the changes from acts-project#3030, that were reverted in the meantime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins
Projects
None yet
Milestone
v34.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulgessinger @acts-project-service @AJPfleger @andiwand