Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong network size written to onnx #3072

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Corentin-Allaire
Copy link
Contributor

This PR fix an issue for the seed selection NN where the wrong network size would be written to the onnx file. The default network are unaffected as they where written before this mistake was introduced.

@github-actions github-actions bot added Component - Examples Affects the Examples module Ambiguity Resolution labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.06%. Comparing base (4271243) to head (a5aa62a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3072   +/-   ##
=======================================
  Coverage   49.06%   49.06%           
=======================================
  Files         495      495           
  Lines       28978    28978           
  Branches    13740    13740           
=======================================
  Hits        14218    14218           
  Misses       4928     4928           
  Partials     9832     9832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJPfleger AJPfleger added this to the next milestone Apr 3, 2024
@kodiakhq kodiakhq bot merged commit adebd58 into acts-project:main Apr 3, 2024
54 checks passed
@github-actions github-actions bot removed the automerge label Apr 3, 2024
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
This PR fix an issue for the seed selection NN where the wrong network size would be written to the onnx file. The default network are unaffected as they where written before this mistake was introduced.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
This PR fix an issue for the seed selection NN where the wrong network size would be written to the onnx file. The default network are unaffected as they where written before this mistake was introduced.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
This PR fix an issue for the seed selection NN where the wrong network size would be written to the onnx file. The default network are unaffected as they where written before this mistake was introduced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants