Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix make_error_code(TrackExtrapolationErrorCategory) #3076

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 4, 2024

Oversight which produces segfaults

@andiwand andiwand added this to the next milestone Apr 4, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Apr 4, 2024
@andiwand andiwand changed the title fix: make_error_code(TrackExtrapolationErrorCategory) fix: Fix make_error_code(TrackExtrapolationErrorCategory) Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 49.05%. Comparing base (1549ccb) to head (38faa77).

Files Patch % Lines
Core/src/Utilities/TrackHelpers.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3076      +/-   ##
==========================================
- Coverage   49.06%   49.05%   -0.01%     
==========================================
  Files         494      494              
  Lines       28972    28973       +1     
  Branches    13739    13740       +1     
==========================================
  Hits        14214    14214              
- Misses       4922     4923       +1     
  Partials     9836     9836              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked for further occurrences in ACTS, but this one seems to be the last one missing a static.

@kodiakhq kodiakhq bot merged commit b0c64a0 into acts-project:main Apr 4, 2024
57 checks passed
@github-actions github-actions bot removed the automerge label Apr 4, 2024
@andiwand andiwand deleted the fix-trackhelpers-error-category branch April 4, 2024 11:59
andiwand added a commit that referenced this pull request Apr 11, 2024
Resurrect #2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- #3074
- #3075
- #3076
- #3077
- #3078
- #3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants