Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use makeX to construct tracks and track states #3074

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 4, 2024

Replaces getX(addX()) with the helper makeX()

@andiwand andiwand added this to the next milestone Apr 4, 2024
@andiwand andiwand changed the title refactor: Use makeX for tracks and track states refactor: Use makeX for tracks and track states Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 49.05%. Comparing base (9c8141e) to head (4adbdf7).

Files Patch % Lines
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 0.00% 3 Missing and 3 partials ⚠️
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 33.33% 0 Missing and 2 partials ⚠️
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 0.00% 0 Missing and 1 partial ⚠️
Core/include/Acts/TrackFitting/KalmanFitter.hpp 0.00% 0 Missing and 1 partial ⚠️
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3074   +/-   ##
=======================================
  Coverage   49.04%   49.05%           
=======================================
  Files         494      494           
  Lines       28979    28972    -7     
  Branches    13746    13741    -5     
=======================================
- Hits        14214    14211    -3     
  Misses       4929     4929           
+ Partials     9836     9832    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand changed the title refactor: Use makeX for tracks and track states refactor: Use makeX to construct tracks and track states Apr 4, 2024
@kodiakhq kodiakhq bot merged commit 93c3dd0 into acts-project:main Apr 4, 2024
52 checks passed
@github-actions github-actions bot removed the automerge label Apr 4, 2024
@andiwand andiwand deleted the refactor-trackedm-use-makeX branch April 4, 2024 18:05
andiwand added a commit that referenced this pull request Apr 11, 2024
Resurrect #2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- #3074
- #3075
- #3076
- #3077
- #3078
- #3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
…ect#3074)

Replaces `getX(addX())` with the helper `makeX()`
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…ect#3074)

Replaces `getX(addX())` with the helper `makeX()`
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…ect#3074)

Replaces `getX(addX())` with the helper `makeX()`
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants