-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use makeX
to construct tracks and track states
#3074
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:refactor-trackedm-use-makeX
Apr 4, 2024
Merged
refactor: Use makeX
to construct tracks and track states
#3074
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:refactor-trackedm-use-makeX
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Component - Documentation
Affects the documentation
Event Data Model
Track Finding
Track Fitting
Ambiguity Resolution
labels
Apr 4, 2024
andiwand
changed the title
refactor: Use makeX for tracks and track states
refactor: Use Apr 4, 2024
makeX
for tracks and track states
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3074 +/- ##
=======================================
Coverage 49.04% 49.05%
=======================================
Files 494 494
Lines 28979 28972 -7
Branches 13746 13741 -5
=======================================
- Hits 14214 14211 -3
Misses 4929 4929
+ Partials 9836 9832 -4 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 4adbdf7physmon summary
|
andiwand
changed the title
refactor: Use
refactor: Use Apr 4, 2024
makeX
for tracks and track statesmakeX
to construct tracks and track states
paulgessinger
approved these changes
Apr 4, 2024
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…ect#3074) Replaces `getX(addX())` with the helper `makeX()`
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <stefl.andreas@gmail.com> Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…ect#3074) Replaces `getX(addX())` with the helper `makeX()`
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <stefl.andreas@gmail.com> Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…ect#3074) Replaces `getX(addX())` with the helper `makeX()`
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <stefl.andreas@gmail.com> Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ambiguity Resolution
Component - Core
Affects the Core module
Component - Documentation
Affects the documentation
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Event Data Model
Track Finding
Track Fitting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
getX(addX())
with the helpermakeX()