Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(DD4hep): change logger level for conversion fail #3092

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Apr 9, 2024

resolves #3080, as discussed on 09.04.2024 in the developers meeting.

@AJPfleger AJPfleger added this to the next milestone Apr 9, 2024
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Apr 9, 2024
andiwand
andiwand previously approved these changes Apr 10, 2024
Plugins/DD4hep/src/ConvertDD4hepDetector.cpp Show resolved Hide resolved
andiwand
andiwand previously approved these changes Apr 10, 2024
@kodiakhq kodiakhq bot merged commit 5d3461f into acts-project:main Apr 10, 2024
51 checks passed
@AJPfleger AJPfleger deleted the dd4hepconversionwarning branch April 10, 2024 11:40
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Apr 10, 2024
@AJPfleger AJPfleger removed the Breaks Athena build This PR breaks the Athena build label Apr 10, 2024
@AJPfleger
Copy link
Contributor Author

Athena integration broke before with #3093. This PR is not related.

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Apr 11, 2024
@andiwand andiwand removed the Fails Athena tests This PR causes a failure in the Athena tests label Apr 11, 2024
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
…ct#3092)

resolves acts-project#3080, as discussed on 09.04.2024 in the developers meeting.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…ct#3092)

resolves acts-project#3080, as discussed on 09.04.2024 in the developers meeting.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…ct#3092)

resolves acts-project#3080, as discussed on 09.04.2024 in the developers meeting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger level when dd4hep conversion fails is only info
3 participants