Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix EigenStepper step upscaling #3152

Merged
merged 15 commits into from
May 27, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 28, 2024

The EigenStepper should use the same formula for up and downscaling the step size. Also according to https://cds.cern.ch/record/1113528/files/ATL-SOFT-PUB-2009-001.pdf we should use a factor 4 as a margin for rejecting the attempted step.

@andiwand andiwand added this to the next milestone Apr 28, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Apr 28, 2024
@andiwand andiwand marked this pull request as draft April 28, 2024 18:21
@andiwand andiwand changed the title perf: EigenStepper step upscaling when necessary fix: EigenStepper step upscaling Apr 29, 2024
@andiwand
Copy link
Contributor Author

image image

@andiwand andiwand marked this pull request as ready for review April 29, 2024 19:34
@andiwand andiwand changed the title fix: EigenStepper step upscaling fix: Fix EigenStepper step upscaling Apr 29, 2024
@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Apr 30, 2024
@andiwand
Copy link
Contributor Author

This is blocked for now because I had to work around a navigation issue which should be resolved before this goes in

Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@8553575). Learn more about missing BASE report.

Current head 24ce23f differs from pull request most recent head f95a01b

Please upload reports for the commit f95a01b to get more accurate results.

Files Patch % Lines
Core/include/Acts/Propagator/EigenStepper.ipp 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3152   +/-   ##
=======================================
  Coverage        ?   47.62%           
=======================================
  Files           ?      507           
  Lines           ?    29172           
  Branches        ?    14000           
=======================================
  Hits            ?    13894           
  Misses          ?     5259           
  Partials        ?    10019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label May 27, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Changes Performance labels May 27, 2024
@kodiakhq kodiakhq bot merged commit 8ad346b into acts-project:main May 27, 2024
53 checks passed
@andiwand andiwand deleted the perf-eigenstepper-step-scaling branch May 27, 2024 09:40
@acts-project-service acts-project-service added Fails Athena tests This PR causes a failure in the Athena tests Breaks Athena build This PR breaks the Athena build labels May 27, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 31, 2024
The `EigenStepper` should use the same formula for up and downscaling the step size. Also according to https://cds.cern.ch/record/1113528/files/ATL-SOFT-PUB-2009-001.pdf we should use a factor 4 as a margin for rejecting the attempted step.
@andiwand andiwand modified the milestones: next, v35.1.0 Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants