-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove step trial count from ConstrainedStep
#3160
Merged
kodiakhq
merged 5 commits into
acts-project:main
from
andiwand:refactor-move-step-trials-from-constrained-step
Apr 30, 2024
Merged
refactor: Remove step trial count from ConstrainedStep
#3160
kodiakhq
merged 5 commits into
acts-project:main
from
andiwand:refactor-move-step-trials-from-constrained-step
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
labels
Apr 29, 2024
📊: Physics performance monitoring for 80bc43fphysmon summary
|
…e-step-trials-from-constrained-step
niermann999
previously approved these changes
Apr 30, 2024
acts-policybot
bot
dismissed
niermann999’s stale review
April 30, 2024 09:06
Invalidated by push of 291cf3b
niermann999
approved these changes
Apr 30, 2024
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…t#3160) This moves the step trial count out of `ConstrainedStep` and counts the total step trials within the stepper state.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…t#3160) This moves the step trial count out of `ConstrainedStep` and counts the total step trials within the stepper state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the step trial count out of
ConstrainedStep
and counts the total step trials within the stepper state.