Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove step trial count from ConstrainedStep #3160

Conversation

andiwand
Copy link
Contributor

This moves the step trial count out of ConstrainedStep and counts the total step trials within the stepper state.

@andiwand andiwand added this to the next milestone Apr 29, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels Apr 29, 2024
niermann999
niermann999 previously approved these changes Apr 30, 2024
@kodiakhq kodiakhq bot merged commit d1d90b3 into acts-project:main Apr 30, 2024
51 checks passed
@andiwand andiwand deleted the refactor-move-step-trials-from-constrained-step branch April 30, 2024 15:48
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…t#3160)

This moves the step trial count out of `ConstrainedStep` and counts the total step trials within the stepper state.
@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…t#3160)

This moves the step trial count out of `ConstrainedStep` and counts the total step trials within the stepper state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants