Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Core CKF segfault with fitted params #3203

Merged
merged 3 commits into from
May 22, 2024
Merged

fix: Fix Core CKF segfault with fitted params #3203

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
220ab02
fix: Fix Core CKF segfault with fitted params
andiwand May 22, 2024
ed74323
revert full chain
andiwand May 22, 2024
cc16461
Merge branch 'main' into fix-ckf-segfault-fittedparams
kodiakhq[bot] May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ class CombinatorialKalmanFilter {
ACTS_ERROR("Error while acquiring bound state for target surface: "
<< res.error() << " " << res.error().message());
result.lastError = res.error();
} else {
} else if (!result.activeTips.empty()) {
AJPfleger marked this conversation as resolved.
Show resolved Hide resolved
const auto& fittedState = *res;
std::size_t currentTip = result.activeTips.back().first;
// Assign the fitted parameters
Expand Down
Loading