Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Core CKF segfault with fitted params #3203

Merged
merged 3 commits into from
May 22, 2024

Conversation

andiwand
Copy link
Contributor

This fixes a rare bug in the CKF. During extrapolation to the target surface we expect a previous track state which does not need to exist necessarily.

#3161 also cleans this up by having tracks for each branch instead of last tip states

@andiwand andiwand added this to the next milestone May 22, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Finding labels May 22, 2024
@kodiakhq kodiakhq bot merged commit 1dfef95 into acts-project:main May 22, 2024
50 checks passed
@andiwand andiwand deleted the fix-ckf-segfault-fittedparams branch May 22, 2024 13:08
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label May 22, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 31, 2024
This fixes a rare bug in the CKF. During extrapolation to the target surface we expect a previous track state which does not need to exist necessarily.

acts-project#3161 also cleans this up by having tracks for each branch instead of last tip states
@andiwand andiwand modified the milestones: next, v35.1.0 Jun 1, 2024
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
This fixes a rare bug in the CKF. During extrapolation to the target surface we expect a previous track state which does not need to exist necessarily.

acts-project#3161 also cleans this up by having tracks for each branch instead of last tip states
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants