Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wire grid size for AMVF and AdaptiveGridSeeder to Python in Examples #3329

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jun 25, 2024

Until now it was not possible to change the grid granularity of the AdaptiveGridSeeder for the AMVF which makes it hard to study effects of these parameters on the performance (physics and CPU). I am wiring these parameters here.

Example of how to use this

addVertexFitting(
    ...
    vertexFinder=VertexFinder.AMVF,
    seeder=acts.VertexSeedFinder.AdaptiveGridSeeder,
    useTime=True,
    spatialBinExtent=15.0 * u.um,
    temporalBinExtent=19.0 * u.mm,
)

@andiwand andiwand added this to the next milestone Jun 25, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Vertexing labels Jun 25, 2024
Copy link

sonarcloud bot commented Jun 25, 2024

@kodiakhq kodiakhq bot merged commit 3d9c957 into acts-project:main Jun 26, 2024
53 checks passed
@andiwand andiwand deleted the ex-vertexing-wire-grid-size branch June 26, 2024 07:06
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
edit: Oh, to late :D

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jun 26, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants