-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Wire grid size for AMVF
and AdaptiveGridSeeder
to Python in Examples
#3329
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:ex-vertexing-wire-grid-size
Jun 26, 2024
Merged
feat: Wire grid size for AMVF
and AdaptiveGridSeeder
to Python in Examples
#3329
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:ex-vertexing-wire-grid-size
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
Affects the Examples module
Vertexing
labels
Jun 25, 2024
📊: Physics performance monitoring for b7dac2cphysmon summary
|
Quality Gate passedIssues Measures |
paulgessinger
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
edit: Oh, to late :D
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Examples
Affects the Examples module
Fails Athena tests
This PR causes a failure in the Athena tests
Vertexing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now it was not possible to change the grid granularity of the
AdaptiveGridSeeder
for theAMVF
which makes it hard to study effects of these parameters on the performance (physics and CPU). I am wiring these parameters here.Example of how to use this