Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ESM, update to latest dependencies #128

Merged
merged 12 commits into from
Feb 9, 2023
Merged

Upgrade to ESM, update to latest dependencies #128

merged 12 commits into from
Feb 9, 2023

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Feb 6, 2023

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 6, 2023
View reviewed changes
src/app.js Outdated
});
app.use(express.static(config.webRoot, { index: false }));

app.get('/*', (req, res) => res.sendFile(config.webRoot + '/index.html'));

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [a file system access](1), but is not rate-limited.
@j-f1 j-f1 marked this pull request as ready for review February 7, 2023 19:42
@MatissJanis
Copy link
Member

FYI: conflicts

@j-f1
Copy link
Contributor Author

j-f1 commented Feb 8, 2023

Rebased!

MatissJanis
MatissJanis reviewed Feb 8, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
MatissJanis
MatissJanis approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review labels Feb 9, 2023
@j-f1 j-f1 merged commit be1c119 into master Feb 9, 2023
@j-f1 j-f1 deleted the jed/esm branch February 9, 2023 18:57
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatissJanis MatissJanis MatissJanis approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-f1 @MatissJanis