Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the API #1074

Closed
j-f1 opened this issue May 29, 2023 · 3 comments
Closed

Add tests for the API #1074

j-f1 opened this issue May 29, 2023 · 3 comments
Labels
API Issues with the @actual-app/api package maintenance Related to making the project easier to maintain tech debt Technical debt we should pay down

Comments

@j-f1
Copy link
Contributor

j-f1 commented May 29, 2023

Presently, there are no automated tests for the API beyond making sure it builds successfully. We should have some tests that spin up a server, run through some/all of the supported ops, and check a few error cases. This would make it less likely that unrelated changes would accidentally break the API.

@j-f1 j-f1 added tech debt Technical debt we should pay down maintenance Related to making the project easier to maintain API Issues with the @actual-app/api package labels May 29, 2023
@twk3
Copy link
Contributor

twk3 commented Dec 5, 2023

with #1991 and #2036 about half the current API functions are covered

should be short work to finish the rest

@MatissJanis
Copy link
Member

@twk3 I believe we can now close this issue. Can you confirm?

@twk3
Copy link
Contributor

twk3 commented Mar 27, 2024

Yes let's close it. There are a few less common handlers like runQuery that aren't covered. But all the ones that represent entities are now in place.

@twk3 twk3 closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues with the @actual-app/api package maintenance Related to making the project easier to maintain tech debt Technical debt we should pay down
Projects
None yet
Development

No branches or pull requests

3 participants