Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-fetch in the API to fix connection drop issue #1397

Merged
merged 13 commits into from
Jul 29, 2023
Merged

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jul 24, 2023

We’ll now hint that the file ID might be incorrect if that’s the type of error we get.

Fixes #1394 by updating node-fetch (unconfirmed)

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 2f6e090
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64c4fe8df3b54500088c9821
😎 Deploy Preview https://deploy-preview-1397.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Bundle Stats - desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.08 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 848.64 KB 0%
static/js/457.chunk.js 388.22 KB 0%
static/media/Inter-italic.var.woff2 239.29 KB 0%
static/media/Inter-roman.var.woff2 221.86 KB 0%
static/js/wide-components.chunk.js 159.28 KB 0%
static/js/383.chunk.js 117.35 KB 0%
static/js/reports.chunk.js 32.25 KB 0%
static/js/narrow-components.chunk.js 31.94 KB 0%
static/js/281.chunk.js 28.55 KB 0%
static/js/876.chunk.js 26.2 KB 0%
static/js/969.chunk.js 12.94 KB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 KB 0%
static/css/main.css 5.82 KB 0%
asset-manifest.json 2.07 KB 0%
index.html 1.66 KB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Bundle Stats - loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB -> 1.97 MB (+147 B) +0.01%
Changeset
File Δ Size
packages/loot-core/src/server/cloud-storage.ts 📈 +157 B (+1.43%) 10.69 KB -> 10.84 KB
packages/loot-core/src/platform/server/fetch/index.web.ts 📉 -88 B (-69.84%) 126 B -> 38 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1010.95 KB -> 1011.09 KB (+147 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1004.04 KB 0%

@MatissJanis
Copy link
Member

Oops.. you added the stats.json file.

@j-f1
Copy link
Contributor Author

j-f1 commented Jul 25, 2023

Good catch!

@j-f1 j-f1 changed the title Add yet more error logging when downloading a file from the server Update node-fetch in the API to fix connection drop issue Jul 25, 2023
Copy link

@toebbel toebbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that fixed connection issues to instances of actual-server running on fly.io

@@ -1,8 +1,9 @@
import * as api from './index';
let api = require('./dist/index');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests shouldn't rely on the compiled code, but instead the source. Any way we can change this back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should be testing the compiled code to make sure that it actually behaves correctly. It isn’t automatically run at this point (#1074) but running directly against the source somehow could give us false confidence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually.. this file is not even used. So I would vote to kill it off entirely.

Even when we add proper tests to api: it won't really make much sense since it's not really a unit test or a e2e test. Just some weird leftover I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@j-f1 j-f1 merged commit a99e88b into master Jul 29, 2023
16 checks passed
@j-f1 j-f1 deleted the jed/more-logging branch July 29, 2023 12:24
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jul 29, 2023
@j-f1
Copy link
Contributor Author

j-f1 commented Jul 29, 2023

Can you do a release? (Also fine to wait if you want to do it with the other August releases)

@MatissJanis
Copy link
Member

Lets do it with August release.

FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: api can't download remote file
3 participants