Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goals: fix broken parser #1059

Merged
merged 2 commits into from
May 25, 2023
Merged

Goals: fix broken parser #1059

merged 2 commits into from
May 25, 2023

Conversation

youngcw
Copy link
Contributor

@youngcw youngcw commented May 25, 2023

Revert the parser cleanup that broke parsing for some goal templates. Undoes some changes from #1052.

@shall0pass How is this. It works for me on the previously broken templates.

@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 939d234
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/646eb056c1f8b500088f9398
😎 Deploy Preview https://deploy-preview-1059--actualbudget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shall0pass
Copy link
Contributor

shall0pass commented May 25, 2023

Better. A lot of the others seem to be working again. I'll have to set up a file with a lot of the examples to make sure they're running. I'm uploading the test file I used to test some of these. I was just changing the text in the notes to add the $ symbols to see what was working.

2023-05-24-Templates_testing.zip

#template-1 schedule Netflix is working.
#template schedule Netflix is not.
#template $50 up to $300 is not working. works without the $ symbols
#template $500 by 2024-03 is not working. works without the $ symbol
#template 10% of Income is not working.
#template 10% of all income is not working.

@youngcw
Copy link
Contributor Author

youngcw commented May 25, 2023

Ive tried all of those, with and without priorities, and Im not having any trouble. ?? Ill try that example

@shall0pass
Copy link
Contributor

shall0pass commented May 25, 2023

Ive tried all of those, with and without priorities, and Im not having any trouble. ?? Ill try that example

HOLD ON! I did the ID10T thing. I was on the master branch testing and not on your PR, lol. I'll recheck now.

Edit: It's all working. Sorry for the false alarm!

@youngcw
Copy link
Contributor Author

youngcw commented May 25, 2023

Ok, I was wondering if that was the case.
image
Seems to be as expected. This is a nice test. Ill be holding on to it

@j-f1 j-f1 merged commit 0d2d861 into actualbudget:master May 25, 2023
@trafico-bot trafico-bot bot added ✅ Approved ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review ✨ Merged Pull Request has been merged successfully labels May 25, 2023
@youngcw youngcw deleted the parser_fix branch May 26, 2023 04:23
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants