-
-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docker-compose file #11
Conversation
Seems like if we're going to add a docker-compose file we should first have a Dockerfile and use that inside the compose file. Right? |
Actually I see now that the actual-server project has a Dockerfile. It still seems like the docker-compose we add in here should be using an official Docker image that's controlled by the maintainers of this repo. |
@boushley Agreed, I do not believe there is an "officially" supported docker image maintained by the repo. |
That's definitely the way it looks currently. We should look at getting setup as an open source project on Docker Hub: https://www.docker.com/community/open-source/application/ |
To be honest I'm a little confused. The artifacts of building this is two things: a JS bundle meant to be included as a web worker for the backend, and a JS bundle for the frontend. We publish those through npm: |
This uses the port 5006, which makes me believe you really wanted https://github.com/actualbudget/actual-server Or a separate project is that just a server that serves up the app without a syncing server? |
@jlongster I think the confusion was around the actual-server repo referenced in the documentation versus this. Many people will land at this main repo and not make the connection to the actual-server repo (which this docker-compose serves up). |
I will update docs to try to clarify this. We can close this PR and favor actualbudget/actual-server#7, correct? |
Pulling in latest from actual collective
File cleanup
fix: add missing comma to jest.config.js
Remove unused imports
build: remove unused patch
Timestamp test suite fix
I think we can close this PR. It's had a lot of my PRs merged into it so it's doing a lot of things other than adding a docker-compose file anyway. |
Sorry for the delay here y'all -- I'm cleaning up PRs now Agree, let's close this and please re-open with fresh changes if there's anything here. This isn't the right repo for docker settings, |
Adds a very basic docker-compose file using Kovah's docker image of the server. Persists data via the volume mounting on
$DOCKERDIR/actual/data:/data
.User should define $DOCKERDIR or set it to a relative path on the docker server.