Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a basic docker-compose file #7

Merged
merged 2 commits into from
May 19, 2022

Conversation

Kk-ships
Copy link
Contributor

No description provided.

Copy link
Contributor

@nathan-isaac nathan-isaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is /data the correct volume location for the actual server data?

@matthewbahr
Copy link

Isn't it better to put the data in /usr/share/?

That's what my homeassistant docker compose does.

docker-compose.yml Outdated Show resolved Hide resolved
Co-authored-by: Nathan Isaac <nathanjisaac@users.noreply.github.com>
@nathan-isaac
Copy link
Contributor

I just tested this locally on my machine. Seems to work good.

Copy link

@fedme fedme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! (I am not a maintainer, just a random dev 😃)

@jlongster
Copy link
Contributor

Is this still up-to-date given the latest docker file changes?

@Kk-ships
Copy link
Contributor Author

Kk-ships commented May 3, 2022

@jlongster docker-compose file would be Dockerfile agnostic. I just builds a docker container based on Dockerfile contents.

@jlongster
Copy link
Contributor

Yes but now we have two different docker files after #22, Dockerfile and Dockerfile.alpine. Does that make a difference?

@Kk-ships
Copy link
Contributor Author

Kk-ships commented May 3, 2022

@jlongster build based on Dockerfile would be larger in size. If someone want's to use alpine build they can change dockerfile argument from Dockerfile to Dockerfile.alpine. Only difference would be container size.

@nathan-isaac
Copy link
Contributor

To continue what @Kk-ships has said, it really depends on how we intend to use this docker-compose.yml file. In my experience, the docker-compose.yml file is mostly copied and modified for production use cases. The docker-compose.yml file in a project like this would mostly be for testing, development, and demo purposes. My suggestion would be to keep it pointing to the Dockerfile and if someone wants to change it they can create their own docker-compose.{name}.yml with the changes they want. Might be something we might want to add to the readme.

@jlongster
Copy link
Contributor

Thanks, I'll add this!

@jlongster jlongster merged commit 6d52cc7 into actualbudget:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants