-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a basic docker-compose file #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is /data
the correct volume location for the actual server data?
Isn't it better to put the data in /usr/share/? That's what my homeassistant docker compose does. |
Co-authored-by: Nathan Isaac <nathanjisaac@users.noreply.github.com>
I just tested this locally on my machine. Seems to work good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! (I am not a maintainer, just a random dev 😃)
Is this still up-to-date given the latest docker file changes? |
@jlongster docker-compose file would be Dockerfile agnostic. I just builds a docker container based on Dockerfile contents. |
Yes but now we have two different docker files after #22, |
@jlongster build based on Dockerfile would be larger in size. If someone want's to use alpine build they can change |
To continue what @Kk-ships has said, it really depends on how we intend to use this |
Thanks, I'll add this! |
No description provided.