Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reports more responsive #1592

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Conversation

OlegWock
Copy link
Contributor

This is work-in-progress. Creating PR so there will be public preview link

This PR makes reports (net worth and category spending) more responsive and makes them utilize all vertical space.

In plans: make all reports remember last used parameters (filters and date range)

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit e0b3b58
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64efa822caa89b00084b2003
😎 Deploy Preview https://deploy-preview-1592.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegWock
Copy link
Contributor Author

Damn, didn't know tests are run on draft PRs too 😥

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
14 2.13 MB → 2.13 MB (+111 B) +0.00%
Changeset
File Δ Size
src/components/reports/graphs/NetWorthGraph.tsx 📈 +40 B (+2.02%) 1.93 kB → 1.97 kB
src/components/reports/NetWorth.js 📈 +30 B (+0.82%) 3.58 kB → 3.6 kB
src/components/reports/CategorySpending.js 📈 +30 B (+0.76%) 3.87 kB → 3.9 kB
src/components/forms.tsx 📈 +13 B (+0.73%) 1.73 kB → 1.75 kB
src/components/reports/CategorySelector.tsx 📈 +11 B (+0.36%) 2.97 kB → 2.98 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/reports.chunk.js 40.69 kB → 40.79 kB (+98 B) +0.24%
static/js/main.js 968.13 kB → 968.14 kB (+13 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/171.chunk.js 396.24 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/wide-components.chunk.js 137.29 kB 0%
static/js/383.chunk.js 117.35 kB 0%
static/js/narrow-components.chunk.js 25.23 kB 0%
static/js/969.chunk.js 12.94 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 kB 0%
static/css/main.css 5.82 kB 0%
asset-manifest.json 1.78 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1017.9 kB 0%
xfo.xfo.kcab.worker.js 1004.04 kB 0%

@MatissJanis MatissJanis changed the title Make reports more responsive & remember last used parameters [WIP] Make reports more responsive & remember last used parameters Aug 26, 2023
@OlegWock
Copy link
Contributor Author

I reduced scope of this PR to just making reports more responsive. Making reports remember last used settings turned out to be a lot more complex than I thought initially, and I'm not sure if I'm up to this challenge.

@OlegWock OlegWock marked this pull request as ready for review August 30, 2023 20:21
@OlegWock OlegWock changed the title [WIP] Make reports more responsive & remember last used parameters Make reports more responsive Aug 30, 2023
@MatissJanis MatissJanis merged commit 6a0b7d6 into actualbudget:master Sep 3, 2023
18 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Sep 3, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants