Fix submit form on enter key pressed #1634
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
The PR description does not seem to match with the code changes. Are we missing some commits? 🤔
Also cc @shall0pass can you please verify if this fixes the bug you reported?
| @@ -127,7 +127,8 @@ export default function FixEncryptionKey({ | |||
| <Button | |||
| style={{ marginRight: 10 }} | |||
| onClick={() => modalProps.onBack()} | |||
| type="button" | |||
| type="normal" | |||
| isSubmit={false} | |||
There was a problem hiding this comment.
💬 suggestion: setting isSubmit is unnecessary here
There was a problem hiding this comment.
Ah yes you're right
There was a problem hiding this comment.
@MatissJanis updated!
|
This works correctly for me. Thanks! |
syukronrm
force-pushed
the
fix-enter-key
branch
from
43b7eb3
to
adf4328
Compare
|
Thanks! |
trafico-bot
bot
added
✨ Merged
Fix #1582
Root Cause
Adding prop
type="button"on<Button>doesn't work because it doesn't proparagated to HTML<button>.Changes
isSubmit=false.<Button>with proptype="primary"should have be propagated as<button type="submit">, except if it's explicitly has propisSubmit=false.