-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: csv parser delimiter #1774
fix: csv parser delimiter #1774
Conversation
csv parser delimiter && selecting delimiters in csv option
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Thanks. Would you mind adding the changelog file so CI jobs pass? Once that's sorted I'm happy to merge |
@MatissJanis done |
packages/desktop-client/src/components/modals/ImportTransactions.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks!
category: Bugfix
authors: [KaiBelmo]
Fixes #1769
Now you can select delimiters in CSV options when you're uploading a CSV, and it's going to apply to parsing. I've also added a new delimiter '|'.
test files:
Semi22colon.csv
Semicolon.csv
Comma.csv
POC:
![efzgif-5-bc16f83d7d](https://private-user-images.githubusercontent.com/51862296/273538306-9dc2a015-57ba-42fb-a22f-2972f4d22b8b.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzQxOTYsIm5iZiI6MTcyNTE3Mzg5NiwicGF0aCI6Ii81MTg2MjI5Ni8yNzM1MzgzMDYtOWRjMmEwMTUtNTdiYS00MmZiLWEyMmYtMjk3MmY0ZDIyYjhiLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAxVDA2NTgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNjMjdlNjZhNGMyNDkyNmY2MWE0YWQ3ZjRhYWIyYTkzODI5ZWZlMmNiYTUzYWYxM2FhZWY3MzI1MzAzYmRlNGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Ku7f5HqJcLtfkYGRCTNlzvz9BiZnTAn_1deMYrYP5z8)