Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: csv parser delimiter #1774

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

KaiBelmo
Copy link
Contributor

@KaiBelmo KaiBelmo commented Oct 9, 2023


category: Bugfix
authors: [KaiBelmo]

Fixes #1769

Now you can select delimiters in CSV options when you're uploading a CSV, and it's going to apply to parsing. I've also added a new delimiter '|'.

test files:
Semi22colon.csv
Semicolon.csv
Comma.csv

POC:
efzgif-5-bc16f83d7d

csv parser delimiter && selecting delimiters in csv option
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit c88bab9
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/652456d975b58d0007313f59
😎 Deploy Preview https://deploy-preview-1774.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.48 MB → 2.48 MB (-2 B) -0.00%
Changeset
File Δ Size
src/components/modals/ImportTransactions.js 📈 +173 B (+0.41%) 41.03 kB → 41.2 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/main.js 1.12 MB → 1.12 MB (-2 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/678.chunk.js 420.74 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/wide-components.chunk.js 126.84 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 34.74 kB 0%
static/js/reports.chunk.js 29.23 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/389.chunk.js 12.77 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@MatissJanis
Copy link
Member

Thanks. Would you mind adding the changelog file so CI jobs pass? Once that's sorted I'm happy to merge

@KaiBelmo
Copy link
Contributor Author

KaiBelmo commented Oct 9, 2023

@MatissJanis done

upcoming-release-notes/1774.md Outdated Show resolved Hide resolved
upcoming-release-notes/1774.md Outdated Show resolved Hide resolved
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks!

@MatissJanis MatissJanis merged commit 3dfe633 into actualbudget:master Oct 9, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Oct 9, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue importing CSV with semicolon deliminter
2 participants