Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile auto decimal #2536

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Mobile auto decimal #2536

merged 8 commits into from
Apr 4, 2024

Conversation

ilar
Copy link
Contributor

@ilar ilar commented Mar 31, 2024

This PR is to add the functionality from #1509 for mobile transactions, as well as display formatting while in the process of editing to improve readability.

The functionality from 1509 is intended to prevent typos and speed up/ease input on phones by pre-populating the decimal in the third position from the right, much as other budget software does like YNAB does.

As I am unfamiliar with the codebase, I am unsure how well this internationalizes and welcome feedback- I don't know what I don't know, in this case.

Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit aff8679
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/660bed352b6d220008a700a2
😎 Deploy Preview https://deploy-preview-2536.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot changed the title Mobile auto decimal [WIP] Mobile auto decimal Mar 31, 2024
Copy link
Contributor

github-actions bot commented Mar 31, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
11 4.43 MB → 4.43 MB (+373 B) +0.01%
Changeset
File Δ Size
src/components/mobile/transactions/FocusableAmountInput.jsx 📈 +373 B (+6.86%) 5.31 kB → 5.67 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.53 MB → 2.53 MB (+373 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/BalanceTooltip.js 6.12 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/import.js 105.26 kB 0%
static/js/narrow.js 215.48 kB 0%
static/js/wide.js 248.58 kB 0%
static/js/ReportRouter.js 1.17 MB 0%

Copy link
Contributor

github-actions bot commented Mar 31, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@Teprifer
Copy link

I like this functionality, I did pick up a small bug in that it still consumes input when the hide decimal places option is enabled and then displays an incorrect number.

By that I mean with this PR preview, enabling hide decimal, when entering a transaction the first digit entered don't display until you start typing in the third and subsequent. And when digits start appearing the numbers aren't what was entered.

Just entering an 8 at each step:

  1. Blank
  2. '1' displays
  3. '9' displays
  4. '89' displays

@ilar
Copy link
Contributor Author

ilar commented Mar 31, 2024

The bug with hideDecimal should be fixed now- didn't even know that was an option. Thanks for letting me know!

@Teprifer
Copy link

Teprifer commented Apr 1, 2024

The bug with hideDecimal should be fixed now- didn't even know that was an option. Thanks for letting me know!

Awesome! Yeah I didn't think of it initially as I don't use it, just saw it when checking you'd covered the different decimal separators so tried it out.

@ilar ilar changed the title [WIP] Mobile auto decimal Mobile auto decimal Apr 1, 2024
@youngcw youngcw merged commit 2df774d into actualbudget:master Apr 4, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 4, 2024
@ilar ilar deleted the mobile-auto-decimal branch April 11, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants