-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile auto decimal #2536
Mobile auto decimal #2536
Conversation
… populate decimal position.
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
I like this functionality, I did pick up a small bug in that it still consumes input when the hide decimal places option is enabled and then displays an incorrect number. By that I mean with this PR preview, enabling hide decimal, when entering a transaction the first digit entered don't display until you start typing in the third and subsequent. And when digits start appearing the numbers aren't what was entered. Just entering an 8 at each step:
|
The bug with hideDecimal should be fixed now- didn't even know that was an option. Thanks for letting me know! |
Awesome! Yeah I didn't think of it initially as I don't use it, just saw it when checking you'd covered the different decimal separators so tried it out. |
This PR is to add the functionality from #1509 for mobile transactions, as well as display formatting while in the process of editing to improve readability.
The functionality from 1509 is intended to prevent typos and speed up/ease input on phones by pre-populating the decimal in the third position from the right, much as other budget software does like YNAB does.
As I am unfamiliar with the codebase, I am unsure how well this internationalizes and welcome feedback- I don't know what I don't know, in this case.