-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure api types are included in the npm package #2559
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
I would like to have all the imports that end up in the But there are still more errors, when importing the api and running tsc. (If you don't disable |
Further fixes up here: #2676 Remaining two issue:
I'll continue to take a look, but I welcome any assistance picking up these final tasks as well to help speed it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the other fixes in place, we are now ready for this change.
The types certainly aren't complete, but they shouldn't currently result in ts errors at least for users of the api.
Starting fresh with a TypeScript project results in
error TS7016: Could not find a declaration file for module '@actual-app/api'
, but the types are in fact generated during build/release. The@types
directory feels unintentionally excluded from the package.It is worth noting that the
@types
directory has a bit of noise to it, but on balance having types feels more beneficial.