Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Add missing key prop to all modals #2609

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

joel-jeremy
Copy link
Contributor

Add key props to all modals

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 721124a
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/661d796358b177000841bc62
😎 Deploy Preview https://deploy-preview-2609.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot changed the title [Maintenance] Add key prop to all modals [WIP] [Maintenance] Add key prop to all modals Apr 15, 2024
Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.63 MB → 4.63 MB (+126 B) +0.00%
Changeset
File Δ Size
src/components/Modals.tsx 📈 +126 B (+0.87%) 14.11 kB → 14.24 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.96 MB → 2.96 MB (+126 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 56.68 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/wide.js 262.74 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@joel-jeremy joel-jeremy changed the title [WIP] [Maintenance] Add key prop to all modals [Maintenance] Add key prop to all modals Apr 15, 2024
@joel-jeremy joel-jeremy changed the title [Maintenance] Add key prop to all modals [Maintenance] Add kmissing key prop to all modals Apr 15, 2024
@joel-jeremy joel-jeremy changed the title [Maintenance] Add kmissing key prop to all modals [Maintenance] Add missing key prop to all modals Apr 15, 2024
@joel-jeremy joel-jeremy merged commit c71e1d2 into master Apr 16, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the add-modal-keys branch April 16, 2024 17:36
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants