-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Underline in Account Header #2847
Merged
carkom
merged 22 commits into
actualbudget:master
from
Crazypkr1099:accountNavVisualChanges
Jun 11, 2024
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
60718ac
Added underline & Fixed Capitalization in Account Header
Crazypkr1099 d21ba3b
Create 2847.md
Crazypkr1099 6eac564
Merge branch 'master' into accountNavVisualChanges
Crazypkr1099 b08da52
Changed border pixel size, made it more opaque.
Crazypkr1099 20c50a2
Merge branch 'accountNavVisualChanges' of https://github.com/Crazypkr…
Crazypkr1099 87cdca2
removed comments
Crazypkr1099 1e1ecce
Merge branch 'master' into accountNavVisualChanges
Crazypkr1099 56990fd
Update E2E
Crazypkr1099 d5a8703
Merge branch 'accountNavVisualChanges' of https://github.com/Crazypkr…
Crazypkr1099 e73ac75
Required to run E2E in local...
Crazypkr1099 78a326a
Revert "Required to run E2E in local..."
Crazypkr1099 dc0fda7
Revert "Update E2E"
Crazypkr1099 d0e256d
testing...
Crazypkr1099 6d11f5c
testing...
Crazypkr1099 b0ce0cd
Update 2847.md
Crazypkr1099 63d8df3
Underline no longer goes to edge
Crazypkr1099 96c5047
Merge branch 'accountNavVisualChanges' of https://github.com/Crazypkr…
Crazypkr1099 8fe4d6b
vrt
youngcw 46f9c51
Merge branch 'master' into accountNavVisualChanges
youngcw cc28a42
vrt
youngcw 71bd109
fix bad screenshot
youngcw aa3ee33
Merge branch 'master' into accountNavVisualChanges
Crazypkr1099 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+302 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+201 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+285 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-4-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-124 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-5-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-17 Bytes
(100%)
.../e2e/accounts.test.js-snapshots/Accounts-closes-an-account-6-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+91 Bytes
(100%)
...es-a-new-account-and-views-the-initial-balance-transaction-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+92 Bytes
(100%)
...es-a-new-account-and-views-the-initial-balance-transaction-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+83 Bytes
(100%)
...es-a-new-account-and-views-the-initial-balance-transaction-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+18 Bytes
(100%)
...tion-available-funds-overspent-budgeted-and-for-next-month-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+183 Bytes
(100%)
...tion-available-funds-overspent-budgeted-and-for-next-month-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+143 Bytes
(100%)
...tion-available-funds-overspent-budgeted-and-for-next-month-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9 Bytes
(100%)
...est.js-snapshots/Budget-transfer-funds-to-another-category-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+178 Bytes
(100%)
...est.js-snapshots/Budget-transfer-funds-to-another-category-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+133 Bytes
(100%)
...est.js-snapshots/Budget-transfer-funds-to-another-category-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-15 Bytes
(100%)
...snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+85 Bytes
(100%)
...snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...snapshots/Reports-loads-cash-flow-graph-and-checks-visuals-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+65 Bytes
(100%)
...js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+47 Bytes
(100%)
...js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+43 Bytes
(100%)
...js-snapshots/Reports-loads-net-worth-and-cash-flow-reports-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+242 Bytes
(100%)
...snapshots/Reports-loads-net-worth-graph-and-checks-visuals-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+139 Bytes
(100%)
...snapshots/Reports-loads-net-worth-graph-and-checks-visuals-2-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+247 Bytes
(100%)
...snapshots/Reports-loads-net-worth-graph-and-checks-visuals-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-258 Bytes
(100%)
.../e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+96 Bytes
(100%)
.../e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+99 Bytes
(100%)
.../e2e/rules.test.js-snapshots/Rules-checks-the-page-visuals-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-203 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+58 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+99 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+215 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-4-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+226 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+63 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-6-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+149 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+215 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-13 Bytes
(100%)
...e-and-makes-sure-it-is-applied-when-creating-a-transaction-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+103 Bytes
(100%)
...edules.test.js-snapshots/Schedules-checks-the-page-visuals-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+150 Bytes
(100%)
...edules.test.js-snapshots/Schedules-checks-the-page-visuals-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+136 Bytes
(100%)
...edules.test.js-snapshots/Schedules-checks-the-page-visuals-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+121 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+98 Bytes
(100%)
...new-schedule-posts-the-transaction-and-later-completes-it-10-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+3 Bytes
(100%)
...new-schedule-posts-the-transaction-and-later-completes-it-11-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-66 Bytes
(100%)
...new-schedule-posts-the-transaction-and-later-completes-it-12-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+107 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+96 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+174 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-4-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+100 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-5-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+124 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-6-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+46 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-7-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+46 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-8-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+44 Bytes
(100%)
...-new-schedule-posts-the-transaction-and-later-completes-it-9-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+216 Bytes
(100%)
...ettings.test.js-snapshots/Settings-checks-the-page-visuals-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-8 Bytes
(100%)
...ettings.test.js-snapshots/Settings-checks-the-page-visuals-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+158 Bytes
(100%)
...ettings.test.js-snapshots/Settings-checks-the-page-visuals-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+227 Bytes
(100%)
...ons.test.js-snapshots/Transactions-checks-the-page-visuals-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+179 Bytes
(100%)
...ons.test.js-snapshots/Transactions-checks-the-page-visuals-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+38 Bytes
(100%)
...ons.test.js-snapshots/Transactions-checks-the-page-visuals-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+162 Bytes
(100%)
...js-snapshots/Transactions-creates-a-split-test-transaction-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+207 Bytes
(100%)
...js-snapshots/Transactions-creates-a-split-test-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+123 Bytes
(100%)
...js-snapshots/Transactions-creates-a-split-test-transaction-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+217 Bytes
(100%)
....test.js-snapshots/Transactions-creates-a-test-transaction-1-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+220 Bytes
(100%)
....test.js-snapshots/Transactions-creates-a-test-transaction-2-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+149 Bytes
(100%)
....test.js-snapshots/Transactions-creates-a-test-transaction-3-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-117 Bytes
(100%)
...js-snapshots/Transactions-filters-transactions-by-category-7-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-16 Bytes
(100%)
...js-snapshots/Transactions-filters-transactions-by-category-8-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
-78 Bytes
(100%)
...js-snapshots/Transactions-filters-transactions-by-category-9-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+41 Bytes
(100%)
...est.js-snapshots/Transactions-filters-transactions-by-date-7-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+40 Bytes
(100%)
...est.js-snapshots/Transactions-filters-transactions-by-date-8-chromium-linux.png
Oops, something went wrong.
Binary file modified
BIN
+58 Bytes
(100%)
...est.js-snapshots/Transactions-filters-transactions-by-date-9-chromium-linux.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
category: Enhancements | ||
authors: [Crazypkr] | ||
--- | ||
|
||
Add underline to budgeting category |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating some branches with master, there is a console log all the time:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah crap sorry... Didn't know about this. I'll create a PR tonight to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2881