Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:electron: Build electron for Mac Universal arch #3015

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Jul 9, 2024

Improve Electron Mac build to target "Universal" for better performance on Apple Silicon.

NOTE: this will increase the size of the Mac app from 111MB to 182MB

Tested by: michaelhofer - on #3004 (comment)

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 2fa0ba1
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6692cd86f748c8000895489d
😎 Deploy Preview https://deploy-preview-3015.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.95 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 76.15 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.5 kB 0%
static/js/wide.js 272.32 kB 0%
static/js/ReportRouter.js 1.23 MB 0%
static/js/index.js 3.2 MB 0%

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

@MikesGlitch MikesGlitch marked this pull request as ready for review July 13, 2024 18:52
@actual-github-bot actual-github-bot bot changed the title [WIP] :electron: Build electron for Mac universal arch :electron: Build electron for Mac universal arch Jul 13, 2024
@MikesGlitch MikesGlitch changed the title :electron: Build electron for Mac universal arch :electron: Build electron for Mac universal arch Jul 13, 2024
@MikesGlitch MikesGlitch marked this pull request as draft July 13, 2024 19:11
@MikesGlitch MikesGlitch marked this pull request as ready for review July 13, 2024 19:11
@MikesGlitch MikesGlitch changed the title :electron: Build electron for Mac universal arch :electron: Build electron for Mac Universal arch Jul 13, 2024
@twk3 twk3 removed the 🚧 WIP label Jul 13, 2024
@MikesGlitch MikesGlitch reopened this Jul 13, 2024
@actual-github-bot actual-github-bot bot changed the title :electron: Build electron for Mac Universal arch [WIP] :electron: Build electron for Mac Universal arch Jul 13, 2024
@MikesGlitch MikesGlitch changed the title [WIP] :electron: Build electron for Mac Universal arch :electron: Build electron for Mac Universal arch Jul 13, 2024
@MatissJanis MatissJanis linked an issue Jul 13, 2024 that may be closed by this pull request
2 tasks
@MatissJanis MatissJanis merged commit 16e887c into actualbudget:master Jul 13, 2024
36 checks passed
@MikesGlitch MikesGlitch deleted the electron/mac-universal branch July 13, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: macOS desktop app not compiled for Apple Silicon.
3 participants