Avoid pulling in the bundled app from API in backend #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlongster
force-pushed
the
jlongster-avoid-api-bundle
branch
from
8abd71c
to
c4d1303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend imports the
import-ynab4andimport-ynab5packages, which we pulling in@actual-app/apidirectly. When we switched to the API using a full bundled version of the app, this is a problem. The importer packages are special because they are inlined directly into Actual, so although they invoke the API they are actually just running directly against Actual when in the app.We can import just the methods from the API instead, which avoids pulling in the whole bundle. This fixes building the backend, and unblocks us to cut a release. Building the backend previously took many minutes (and resulted in a huge bundle) because it was embedding the API build; now it takes ~30 seconds.