-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prune: remove unused icons #429
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
IMO we should keep the icons since they may be useful in the future — maybe add an ignore to the entire folder for now? |
This looks great! svgs definitely went through some evolution and need some cleanup. Some context: the svgs in the root The And I agree with @j-f1: was gonna suggest just ignoring the whole folder. These are generated files that don't need to be linted. But this cleanup is AWESOME. definitely a messy area! |
This PR doesn't touch v1 or v2 icons btw. Only the legacy ones that are unused. A PR approval ✅ would be appreciated if you think this is good-to-go. |
Yeah, this PR looks good for that reason :) just giving some context when I see stuff! I'm in a rush right now so haven't actually looked to closely to r+ but it should be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks for the cleanup!
…ariables-3 prune: remove unused icons
Removing unused icons and adding
eslint-ignore
rule to the remaining.