Regenerate icons without the .web.js extension #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MatissJanis
approved these changes
Jan 20, 2023
MatissJanis
requested changes
Jan 20, 2023
trafico-bot
bot
added
⚠️ Changes requested
This comment was marked as resolved.
This comment was marked as resolved.
trafico-bot
bot
added
🔍 Ready for Review
and removed
⚠️ Changes requested
|
Thanks for pointing that out! Looks like the sizing got messed up. Switched to |
MatissJanis
approved these changes
Jan 20, 2023
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
* Regenerate icons without the .web.js extension * Move icons in the root folder to a “v0” folder * Remove generated index.js files * Update generator to auto-remove deleted icons * Add back AnimatedLoading + Loading * Add SVG files for missing icons * lint fix * the perils of (not) running a case-sensitive file system * Fix new import * Switch v0 icons from width/height to viewBox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to import since the file name will be correctly completed without the
.websuffix. However, auto-imports will still add theSvgprefix to the component name because there is no way to remove it.