-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate icons without the .web.js extension #485
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I totally forgot to follow up on the icon cleanup after removing the mobile versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - I'm noticing some issues on netlify. Will post in comments.
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for pointing that out! Looks like the sizing got messed up. Switched to |
* Regenerate icons without the .web.js extension * Move icons in the root folder to a “v0” folder * Remove generated index.js files * Update generator to auto-remove deleted icons * Add back AnimatedLoading + Loading * Add SVG files for missing icons * lint fix * the perils of (not) running a case-sensitive file system * Fix new import * Switch v0 icons from width/height to viewBox
This makes it easier to import since the file name will be correctly completed without the
.web
suffix. However, auto-imports will still add theSvg
prefix to the component name because there is no way to remove it.