-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow libofx to handle decoding imported files #591
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Weird, it works fine for me. Did you uncompress the downloaded GZIP file first? Once I do that I’m able to view the |
Yeah, I can't seem to get the file open on OSX. So can someone else on a Win/Linux machine test the change and let me know if it works as expected? I can then do the code review. |
@MatissJanis Can you try with https://raw.githubusercontent.com/actualbudget/actual/b84c58ad0bf1db194ad954b995b8ff6d65d496e1/packages/loot-core/src/mocks/files/8859-1.qfx? That’s the uncompressed version of the file that was shared with us. (I was able to decompress using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @j-f1 ! Was able to reproduce the issue and then also reproduce the fix in the preview deployment.
LGTM
* Allow libofx to handle decoding imported files * Add releve.qfx as a test file * Remove irrelevant redacted transactions from test file * Fix console overload from long console.warn stacks
This avoids assuming that imported OFX files are UTF-8 and defers to libofx, which handles reading the
CHARSET
header in the file and using that encoding to read its content. Fixes #189. (Tested with the provided file and it works fine!)