Add support for credit card OFX files #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MatissJanis
approved these changes
May 2, 2023
trafico-bot
bot
added
✨ Merged
|
Thanks @j-f1, how was the experience of there being a conflict between the two importers? Did everything work out well in terms of identifying that there was an error? Feel free to Ping me in the future if you cant figure out OFX stuff, but I hope the code was easy to figure out! |
|
Hi @sinistersnare! When testing this out on the previous version (https://645151888d1ec80008d0ea13--actualbudget.netlify.app), I just got “Something internally went wrong.” It would be nice to catch errors thrown from both parsers and report them. |
|
Yeah I see how that error came up. I'm on vacation, so hopefully on Tuesday I will remember to fix the error handling for this! |
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My credit card (Apple Card) recently switched from exporting as bank transactions to exporting as credit card transactions. This adds some logic to the importer to handle this case.