Skip to content

Commit

Permalink
Fixing Issue #18
Browse files Browse the repository at this point in the history
  • Loading branch information
Aram committed Mar 17, 2017
1 parent 00c3f62 commit 781c586
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# or
# -mavx2

CRYPTO1_BS_OPTIMIZATION_ARGS=-O3 -march=native -mpopcnt
CRYPTO1_BS_OPTIMIZATION_ARGS=-O3 -march=native
# popcount is used for fast (hardware) parity computation on non-bitsliced states

all: solve_bs solve_piwi_bs solve_piwi libnfc_crypto1_crack
Expand Down

4 comments on commit 781c586

@iceman1001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't popcnt used for fast bit counts?... Don't you need that in yr solver? Speedwise..

@aczid
Copy link
Owner

@aczid aczid commented on 781c586 Mar 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCC will emit that instruction when it's available regardless, and only include some GNU code to emulate it when it's not. -mpopcount is meant to force the compiler to always/only output the instruction.

@iceman1001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I should be able to be without it on pm3 aswell?

@aczid
Copy link
Owner

@aczid aczid commented on 781c586 Mar 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think so.

Please sign in to comment.