Fix ORDER BY and FILTER on COUNT() columns #247 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously we were using the column mapping of the child subtree, however that can be wrong for the result when new columns are added (e.g. by using COUNT()). Somehow this was masked in previous versions of the column mapping.
floriankramer
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #247. Where the first commit just adds a reproducer query to the end to end tests.
It turns out the underlying issue is that the
GroupByoperation would use the subtree column indexes to indicate which columns are already sorted. Upstream operations could then assume a wrong pre-existing order and turnHAVINGinto a binary search on unsorted data or assume anORDER BYto be a no-op.