-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scheme start state #2
Conversation
2024314
to
b55e756
Compare
e3a4d9c
to
2298a8d
Compare
c74662f
to
7c6daf2
Compare
Random comments which you may consider...
parser::parser(const std::string_view input, std::optional<ada::url> optional_base_url,
std::optional<ada::encoding_type> encoding_override): buffer{},
pointer{input.begin()}, encoding{encoding_override.value_or(ada::encoding_type::UTF8)} {
...
} That is, once you enter the curly bracket part of the constructor, your attributes should have a clear state. I think it is considered form to do the initialization in the curly-bracket component of the constructor. std::string_view input{};
std::string buffer{};
bool at_sign_seen{}; // will be false
bool inside_brackets{};
bool password_token_seen{};
|
These are not requests for changes. They are comments. |
Thank you for the review @lemire. Much appreciated. Let's merge this now, and I'll apply your comments in a separate pull request. |
No description provided.