Warning fixes #529
Merged
Warning fixes #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions - Some [[nodiscard]]s added - default argument for `parse_port` which is a virtual function is not recommended, I changed it to two different functions - using `<cstdint>` instead of `<stdint.h>` - Adding `override` for virtual destructors - Small changes like comment missmatch fixes and useless "return" statement removal
anonrig
reviewed
Oct 6, 2023
lemire
reviewed
Oct 6, 2023
lemire
reviewed
Oct 6, 2023
lemire
requested changes
Oct 6, 2023
There was a problem hiding this comment.
I strongly disagree with the change of uint8_t into std::uint8_t. You can verify that Node.js (written in C++) uses uint8_t and not std::uint8_t.
Everything else seems good and should be merged. Thanks.
There are some formatting changes that I am not going to comment upon (I only reviewed semantically relevant changes).
|
This is a good PR. |
|
formatting is done via clang-format v16.0.6 git ls-files | grep -E "\.(h|cpp)\$" | xargs clang-format -iAnd I'm going to change the |
anonrig
approved these changes
Oct 8, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[nodiscard]]s addedparse_portwhich is a virtual function is not recommended, I changed it to two different functions<cstdint>instead of<stdint.h>overridefor virtual destructors