Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When text selected, include index number if needed #5

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

dracos
Copy link
Contributor

@dracos dracos commented Dec 15, 2016

This means that if the “mess” in the last paragraph of Chapter 4 is selected, the hash becomes #mess++2 not just #mess which goes to the first mention.

Fixed version of #3 which copes better (ignores) if text selected across nodes (so no results from getElementsByText which only works for text in one node).

@adactio adactio merged commit f7f1c64 into adactio:master Dec 15, 2016
@adactio
Copy link
Owner

adactio commented Dec 15, 2016

Works a treat! Deployed! Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants