Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clue_ams_remote.py #14

Merged
merged 11 commits into from
Feb 17, 2020
Merged

Added clue_ams_remote.py #14

merged 11 commits into from
Feb 17, 2020

Conversation

evaherrada
Copy link
Collaborator

Was experimenting with using buttons and capacitive touch as a remote using ams to add to pyloton. I thought the test code I wrote could be quite useful, so I'm PRing it. Didn't really want to add displayio to keep it simple and increase responsiveness, although adding that wouldn't take a whole lot of time to do.

@evaherrada evaherrada requested review from kattni and a team February 13, 2020 21:29
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dherrada I have a suggestion. It's not strictly necessary, and if you'd rather not, then I'll merge this as-is. Thanks.

This example solicits that apple devices that provide notifications connect to it, initiates
pairing, then allows the user to use a CLUE board as a media remote through both the buttons
and capacitive touch pads.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if you could include a note in the doc string about the separate libraries needed to run this example. Whenever I include an example in a library-specific repo that requires an atypical library (e.g. adafruit_ble, and adafruit_ble_apple_media), I include a note in the docstring to alleviate any potential confusion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@evaherrada
Copy link
Collaborator Author

evaherrada commented Feb 16, 2020

@kattni I made a version of this on a branch using displayio. It looks pretty cool and I was able to add a visual volume indicator and a visual track time indicator, but it is probably a bit more complex than we'd want for an example. Link if you're interested

@kattni
Copy link
Contributor

kattni commented Feb 16, 2020

@dherrada Make a folder in examples called advanced_examples, rename the advanced example to something other than the same as this one, and feel free to include it that way. There are "duplicate" examples on the Circuit Playground library that are more advanced versions of similar things, so we can do that here as well. You can include it in this PR if you'd like. I'll hold off on approving until you decide.

@evaherrada
Copy link
Collaborator Author

@kattni I made the requested changes

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more simple suggestion. Otherwise, looks good!

This example requires the following additional libraries:
adafruit_ble
adafruit_ble_apple_media
displayio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed - the point of the list is to outline libraries that must be loaded on the board. As displayio is built in, there is no need to point it out here.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! Thanks!

@kattni kattni merged commit 5ac8615 into adafruit:master Feb 17, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 18, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#52 from ares-est/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.0.3 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#17 from kattni/slideshow-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#14 from dherrada/master
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#16 from kattni/slideshow-example
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#15 from kattni/add-display-object
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#12 from kattni/add-space
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#11 from kattni/variable-change
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#10 from kattni/level-bubble-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#9 from kattni/color-fix
  > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#8 from kattni/example-update

Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#11 from stitchesnburns/stitchesnburns-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.0.2 from 2.0.1:
  > Update README.rst

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#5 from BiffoBear/rename-example-file
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#4 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#5 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.2.3 from 2.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#21 from foozmeat/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#5 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.10 from 3.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#65 from cogliano/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.8.9 from 3.8.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#70 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.11 from 1.0.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#17 from caternuson/controller_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.2.0 from 4.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#43 from dhalbert/avoid-alloc

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#10 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_LPS2X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants