Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add I2C support and various example fixes #36

Merged
merged 15 commits into from
Nov 16, 2019
Merged

Add I2C support and various example fixes #36

merged 15 commits into from
Nov 16, 2019

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Nov 3, 2019

Added GPS_I2C for interfacing with simple I2C implementations of GPS modules
Updated all examples to have UART, pyserial and I2C definitions
Fixed weird huge timeouts in UART examples
Removed 'computer' datalogging demo and merged it with the non-computer datalogging demo
Fixed datalogging demo which was missing some imports. Tested on Windows+I2C and Feather M4
Fixed RTC demo, was based on old circuitpython, tested with I2C GPS
Parser now accepts $GN NMEA's used in more modern modules

@ladyada ladyada requested a review from a team November 3, 2019 02:28
@caternuson
Copy link
Contributor

Looks like you are wanting to not make this a breaking change? Otherwise could maybe refactor the classes more like other multi-interface drivers do.

Current (UART only):

GPS

Refactor (breaking)

GPS
GPS_UART(GPS)
GPS_I2C(GPS)

@ladyada
Copy link
Member Author

ladyada commented Nov 6, 2019

correct, also because theres one standard UART interface, but there may be variable I2C/SPI interfaces (they aren't standardized). default GPS should be UART!

@caternuson
Copy link
Contributor

ah, ok. should GPS_I2C be renamed then to reflect that? as is, sounds generic. as if it is standardized.

@ladyada
Copy link
Member Author

ladyada commented Nov 6, 2019

could rename it GPS_GTopI2C ?

@caternuson
Copy link
Contributor

yah. something like that. i don't know the specifics enough to suggest any better. just concerned about implying that there is a standard I2C interface by having just GPS_I2C. and if/when more interfaces get added, what would they be named.

sounds like GTop is the specific interface here?

@ladyada
Copy link
Member Author

ladyada commented Nov 6, 2019

yeah its used for GTop modules 🤷‍♂ :)
ill submit changes

@ladyada
Copy link
Member Author

ladyada commented Nov 16, 2019

@caternuson finally had time to do this! please check it out - tested :)

@ladyada ladyada merged commit f8de4c0 into adafruit:master Nov 16, 2019
@caternuson
Copy link
Contributor

Yep. Looks good. Just a simple naming convention, but seems like a good idea.

@ladyada
Copy link
Member Author

ladyada commented Nov 16, 2019

yaaayyy! doing SPI next

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 16, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@f7bbfc2)
7b03930 
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.5.0 from 3.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#36 from ladyada/master
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#35 from adafruit/dherrada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caternuson caternuson caternuson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @caternuson