Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No LOL'ing with 7x4 Segment #79

Closed
Daviey opened this issue Sep 17, 2020 · 5 comments · Fixed by #80
Closed

No LOL'ing with 7x4 Segment #79

Daviey opened this issue Sep 17, 2020 · 5 comments · Fixed by #80
Labels
enhancement

Comments

@Daviey
Copy link
Contributor

Daviey commented Sep 17, 2020

Seg7x4 is feeling a bit unloved (:broken_heart: & :cry:) and could really do with a laugh to feel a bit better. However, L,l,O,o are prohibited characters and silently dropped.

Please help put a smile on Seg7x4's face. 😆
Daviey added a commit to Daviey/Adafruit_CircuitPython_HT16K33 that referenced this issue Sep 17, 2020
@Daviey
Removed artifical limiting of 7x4 display (LOL)
21ecba6 
I needed more LOL'ing in my life, and a 7x4 segment display can help
with this.

However, adafruit_ht16k33 filters this out for the 7x4 display which
makes me super sad 😢.  This change allows the use of both upper and
lower case L's and O's.

(also, matrix.py and segments.py had the eXecutable bit set, which has
been dropped)

Fixes: adafruit#79
Signed-off-by: Dave Walker (Daviey) <email@daviey.com>
@Daviey Daviey mentioned this issue Sep 17, 2020
Merged
@tekktrik
Copy link
Member

Is this still WIP? I was thinking of implementing a way to add something like a character set to the display that could be used for a few reasons:

  • To add characters not included in display hex numbers
  • To pick how to display characters with multiple ways of showing them ("H" and "h" can both be valid in seven segment)
  • To allow for displaying of characters that don't have clean seven segment displays (I've seen "w" be done in some convoluted way)
  • To allow for non-English letters (Wikipedia shows some other alphabets)

I see a linked PR so I wanted to check in.

@tekktrik
Copy link
Member

Or would it be better to just open it up further under the current implementation, for letters like "L" and "O", but still prevent letters that don't have great representations, like "W"?

@FoamyGuy FoamyGuy mentioned this issue Dec 27, 2021
Closed
@tekktrik
Copy link
Member

tekktrik commented Dec 27, 2021 •
edited
Loading

Thanks for the PR @FoamyGuy! I may work on an implementation that allows for use of a character library as a solution for further letters, let me know if you have any thoughts.

@FoamyGuy
Copy link
Contributor

@tekktrik I like that idea, it would be nice if it had a list of letters that it is able to draw with the segments that it has and could use them with marquee.

@tekktrik
Copy link
Member

Sounds great! I'll get on it in the new year!

@tekktrik tekktrik mentioned this issue Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed artifical limiting of 7x4 display (LOL) Daviey/Adafruit_CircuitPython_HT16K33
4 participants
@Daviey @FoamyGuy @evaherrada @tekktrik