Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't set stepper freq if it's already OK #13

Merged
merged 2 commits into from
Jul 31, 2018
Merged

don't set stepper freq if it's already OK #13

merged 2 commits into from
Jul 31, 2018

Conversation

dhalbert
Copy link
Contributor

Fixes #12.

Some PWM-like classes don't allow setting frequency. Check if frequency is an acceptable value and don't try to change it if it's already OK.

kattni
kattni approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Travis failed on this file and another file in the repo that you didn't change which makes me think it's using the new Pylint. Up to you how you want to handle it.

@kattni kattni merged commit 3559d01 into adafruit:master Jul 31, 2018
@dhalbert dhalbert deleted the stepper-freq branch July 31, 2018 20:06
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 1, 2018
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@e893f58)
ff5a9c4 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.0.7 from 3.0.6:
  > travis: add "overwrite: true" to releases provider

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.2.0 from 3.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#13 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#14 from dhalbert/notimpl-freq-setter

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.0.0 from 0.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#8 from kattni/pypi

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.3.0 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#14 from kattni/pypi
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#13 from dhalbert/stepper-freq
@caternuson caternuson mentioned this pull request Jan 10, 2023
Closed
@tekktrik tekktrik mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

@caternuson caternuson Awaiting requested review from caternuson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhalbert @kattni