PWMOut variable frequency not required, uses only one counter #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddacious
suggested changes
Dec 29, 2018
There was a problem hiding this comment.
Nice catch @plamponi. If you're going to add a constraint to the arguments to the constructor, it would be helpful if you could also update the docstring for the constructor to let people know about it.
Otherwise this looks good
|
Thanks! Added Note to docstring about PWM frequency requirements. Also added my version of the example, and renamed the original example to indicate that it uses a PCA9685. |
siddacious
approved these changes
Dec 30, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 4, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.4.0 from 1.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#23 from plamponi/pwm_freq > Merge pull request adafruit/Adafruit_CircuitPython_Motor#22 from ladyada/master > Merge pull request adafruit/Adafruit_CircuitPython_Motor#21 from sommersoft/readme_fix_travis
siddacious
added a commit
to siddacious/Adafruit_CircuitPython_Motor
that referenced
this pull request
Mar 14, 2019
This reverts commit a889448, reversing changes made to 7f93c2a. (adafruit/Adafruit_CircuitPython_Crickit#15)
kattni
added a commit
that referenced
this pull request
Mar 14, 2019
Revert "Merge pull request #23 from plamponi/pwm_freq"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to set the minimum frequency to 2000 requires
variable_frequency=Truefor all four PWMOut objects. This consumes a counter for each object, and there aren't that many to go around.If the minimum frequency is only checked, but not changed, then
variable_frequencycan beFalseand only one counter is used (assuming the frequency is the same for all the four PWMOut objects).This way, external PWM drivers such as the PCA9685 are not strictly required.
Tested on ItsyBitsy M4 Express + DRV8833.