Skip to content
This repository has been archived by the owner on Apr 20, 2022. It is now read-only.

Update to match _pixelbuf from CP #18

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Update to match _pixelbuf from CP #18

merged 1 commit into from
Apr 25, 2020

Conversation

dunkmann00
Copy link
Contributor

This is meant to bring this python implementation of PixelBuf in line with the version implemented in CP version 5.

@dunkmann00 dunkmann00 mentioned this pull request Apr 24, 2020
Merged
tannewt
tannewt suggested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this! One minor question and then it should be good to go.

adafruit_pypixelbuf.py Show resolved Hide resolved
dhalbert
dhalbert suggested changes Apr 24, 2020
View reviewed changes
adafruit_pypixelbuf.py Outdated Show resolved Hide resolved
tannewt
tannewt approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for pushing this forwards!

@tannewt tannewt merged commit 0b40444 into adafruit:master Apr 25, 2020
@dunkmann00 dunkmann00 deleted the _pixelbuf_cp branch April 25, 2020 04:00
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 1, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@ddcf3f0)
9998db8 
Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.0.0 from 5.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#83 from adafruit/tannewt-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#82 from dunkmann00/pixelbuf

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel_SPI to 0.8.0 from 0.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel_SPI#15 from dunkmann00/pypixelbuf-2.0-compat

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.0.0 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#11 from jimbobbennett/master
  > build.yml: add black formatting check

Updating https://github.com/adafruit/Adafruit_CircuitPython_Pypixelbuf to 2.0.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#19 from dunkmann00/dotstar_brightness
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#18 from dunkmann00/_pixelbuf_cp
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#17 from adafruit/black-update
  > build.yml: add black formatting check
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#16 from kattni/update-example-name
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#12 from adafruit/pylint-update
  > update code of coduct: discord moderation contact section
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#11 from sommersoft/patch_coc
  > update pylintrc for black
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhalbert dhalbert dhalbert requested changes

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunkmann00 @tannewt @dhalbert