_cardCS not set #26
Comments
|
Actually I wounder whether it would make sense to remove the cardCS part completely. Didn't work anyway without any negativ side effects. |
|
fixed and also moved that code (which admittedly isnt used) to begin() since some arduino's dont like to do pin stuff before setup() :) |
TheNitek
pushed a commit
to TheNitek/Adafruit_VS1053_Library
that referenced
this issue
Dec 30, 2018
ladyada
pushed a commit
that referenced
this issue
Jan 21, 2019
* Put in the changes to jump ID3 tags. Apple, and I think windows, has been putting massive ID3 meta tags in the front of .mp3 files. They typically take more than 20 sec. to start playing as the player rolls through this stuff. This fix jumps the file pointer beyond the ID3 tag for a speedy quick startup. * more reasonable delay! * Disable interrupts at the beginning of feedBuffer(), where a flag is checked if feedBuffer is already running, similar to a feature of Paul Stoffregen’s fork, possibly related to issue #4 * Prevent startPlayingFile from triggering the ESP8266 watchdog reset * fix #26 * Clean up lock logic a bit. Pull out a function so the locking code is nice and isolated. Also remove the collision of interrupt disable/enable twiddling that shows up in playFullFile(). * version bump * update demo to be more ESP friendly * update tested on M4 * bump * some chips really need that leading /! * ESP32 seems to now have IRQ support * add feather nrf52840 test * Simplify isMP3File() * Jump ID3 tags when playing file * make isMP3File() static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey,
In the FilePlayer constructors the pin on
_cardCSis set high, however i cannot see anywhere_cardCSis being set and believe it is supposed to be just the local variablecsinstead.On my board the value of
_cardCSis defaulting to 64 on power on and is causing a crash.Thanks, Mitchell
The text was updated successfully, but these errors were encountered: