Improve formatting

[sommersoft]

Fixes #225.

This is a large one, so apologies for the heavy review load.

Changes include the following:

• Ran Black on all Python files

• Ran Pylint and addressed most issues. There are some pylint: disable markers that can be cleaned up, but would be better done outside this PR.

• Actions workflow changes:

  • Updated Python version to 3.9 in all workflows
  • Added pre-commit config and workflow to run black and pylint

• Beyond automated tests, the following were tested (the rest are currently hard to test):

  • adabot/update_cp_org_libraries.py (with -o)
  • adabot/circuitpython_library_patches.py (with --dry-run & --dry-run --local)
  • adabot/circuitpython_library_download_stats.py (with -o)
  • adabot/lib/assign_hacktober_label.py

I've got a small list of new issues to address some of the pylint: disable markers, and some other stuff I came across. I'll get those filed soon.

[evaherrada]

Oh wow, thanks so much for doing this. Yeah, there were an absurd amount of things that needed to be linted here.

[evaherrada]

@sommersoft I can't thank you enough for doing this. Last time I checked Pylint had about 700 things that it wanted changed, I can't imagine how long it took.

[evaherrada]

Testing the scripts:

• arduino_libraries
• update_cp_org_libraries
• circuitpython_libraries
• circuitpython_library_download_stats

[kattni]

This is brilliant, thank you so much for doing it! @dherrada is testing it locally to ensure everything is still copacetic.

@sommersoft I had one question below. I noticed you pinned Black, and I wasn't sure if we should be pinning Pylint as well.

[kattni]

Should this be pinned as well?

[sommersoft]

I noticed you pinned Black, and I wasn't sure if we should be pinning Pylint as well.

I didn't pin it since the locally installed module is used to verify that a library is passing with the latest pylint, in lib/circuitpython_library_validators.py::validate_passing_linting.

However, in looking back at changes to libs/cookiecutter, it seems they're all now pinned to 2.7.1 via pre-commit-config. Which brings the question: is validate_passing_linting overachieving by linting with the latest version?

[evaherrada]

Ok. Just finished running all 4 of the scripts that we can run locally and they all worked as expected.

[kattni]

I'm ok with merging this and if we were supposed to pin Pylint, we can handle it in another PR.

Thank you for testing, Dylan!

Thanks so much for this whole thing, sommersoft!