Update CircuitPython Report Order & Emergency Fix #240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238
Updates report to match desired result:
Emergency Fix
When changing
update_cp_org_libraries
to allow for testing, I used the incorrect method when changing a list variable to a set. Which broke the function (adafruit/circuitpython-org Actions run):This PR contains a fix for that.
Additionally, this break highlighted that the integration test did not catch this error; the mocked
list_repos
usesTestRepo
which will not provide consistent contributor information. So, the test now includes a mocked result for contributor info.Lastly, in running tests before pushing this PR, changes in adafruit/cookiecutter-adafruit-circuitpython#151 caused test failures. I updated the validator function with the new hardcoded link.