Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircuitPython Report Order & Emergency Fix #240

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

sommersoft
Copy link
Collaborator

Fixes #238

Updates report to match desired result:

### Libraries
* 8 pull requests merged
  * 6 authors - makermelissa, rdoursenaud, kattni, tannewt, Neradoc, lesamouraipourpre
  * 8 reviewers - makermelissa, dhalbert, tannewt, antonio-openroad, TheKitty, FoamyGuy, ladyada, kattni
  * Merged pull requests:
    * https://github.com/adafruit/Adafruit_CircuitPython_MIDI/pull/41 (Days open: 36)
    * https://github.com/adafruit/Adafruit_CircuitPython_BLE/pull/135 (Days open: 2)
    * https://github.com/adafruit/Adafruit_CircuitPython_BLE_File_Transfer/pull/13 (Days open: 1)
    * https://github.com/adafruit/Adafruit_CircuitPython_PortalBase/pull/49 (Days open: 1)
    * https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107/pull/9 (Days open: 1)
    * https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741/pull/2 (Days open: 1)
    * https://github.com/adafruit/Adafruit_CircuitPython_TLC59711/pull/19 (Days open: 1)
    * https://github.com/adafruit/Adafruit_CircuitPython_Bundle/pull/343 (Days open: 1)
  * 58 open pull requests (Oldest: 640, Newest: 1)
* 8 closed issues by 8 people, 3 opened by 3 people
  * 345 open issues
  * 4 good first issues
* https://circuitpython.org/contributing
Library updates in the last seven days:

Emergency Fix

When changing update_cp_org_libraries to allow for testing, I used the incorrect method when changing a list variable to a set. Which broke the function (adafruit/circuitpython-org Actions run):

  cd adabot
  python3 -u -m adabot.update_cp_org_libraries -o $GITHUB_WORKSPACE/bin/adabot/libraries.v2.json
Running circuitpython.org/libraries updater...
Run Date: 22 September 2021, 09:22AM
 - Report output will be saved to: /home/runner/work/circuitpython-org/circuitpython-org/bin/adabot/libraries.v2.json
Error retrieving cookiecutter .readthedocs.yml
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/runner/work/circuitpython-org/circuitpython-org/adabot/adabot/update_cp_org_libraries.py", line 306, in <module>
    output_file=cmd_line_args.output_file,
  File "/home/runner/work/circuitpython-org/circuitpython-org/adabot/adabot/update_cp_org_libraries.py", line 241, in main
    contributors.add(get_contribs)
TypeError: unhashable type: 'list'
Error: Process completed with exit code 1.

This PR contains a fix for that.

Additionally, this break highlighted that the integration test did not catch this error; the mocked list_repos uses TestRepo which will not provide consistent contributor information. So, the test now includes a mocked result for contributor info.

Lastly, in running tests before pushing this PR, changes in adafruit/cookiecutter-adafruit-circuitpython#151 caused test failures. I updated the validator function with the new hardcoded link.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kattni kattni merged commit 8715c3c into adafruit:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update order of CircuitPython library report Libraries section
2 participants