Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/fix-daily-release #349

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Jul 6, 2023

Should fix an issue where the auto-tally causes empty bundle releases.

Also updates pre-commit which hadn't been done yet it seemed. I kept everything the same for now, with notes for future linting of things to fix in the new .pylintrc disable list.

Fixes adafruit/Adafruit_CircuitPython_Bundle#432

@tekktrik tekktrik requested review from dhalbert and Neradoc July 6, 2023 03:10
@tekktrik
Copy link
Member Author

tekktrik commented Jul 6, 2023

The critical changes are in adabot/circuitpython_bundle.py

@tekktrik
Copy link
Member Author

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I see now that the way the download statistics were added, they also caused a release to happen. It looks like this is no longer the case after this change...

@tekktrik tekktrik merged commit 012b13e into adafruit:main Jul 11, 2023
3 checks passed
@tekktrik tekktrik deleted the dev/fix-daily-release branch July 11, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle being rebuilt with no library changes
2 participants