PWMOut was not claming channels on shared TCCs #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some builds didn't fit any more by a tiny amount, so I bumped the compiler up to the version I was already using anyway. |
|
Didn't mean to do a PR from adafruit/circuitpython. I had to reclone and recloned from adafruit/ instead of dhalbert/ |
|
This is the direction I was leaning in my "investigation" as well. In that since an existing TCC set at the desired frequency was looked for and used, any subsequent changes to it applied to all latched pins. I had stopped short of digging into the channel aspects before doing some domestics. Nice work @dhalbert! |
tannewt
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1106.
@deshipu - you may want to test this. I did try a test case similar to yours. The code was allocating the same TCC channel to multiple pins. This means that you may run out of timers earlier previously, because we were allocating the same TCC and channel to multiple pins by accident.