Upload mpy-cross builds to S3 #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
force-pushed
the
upload-mpy-cross-to-s3
branch
3 times, most recently
from
7334588
to
cd39be3
Compare
dhalbert
force-pushed
the
upload-mpy-cross-to-s3
branch
from
cd39be3
to
2b6b0e9
Compare
|
I thought I could test this by forcing the upload to happen all the time, but I can't because a fork PR doesn't have access to the secrets. However, in the process of failing to test I did some strawman testing and did fix some problems, so I think it should work when merged. |
jepler
requested changes
Jul 29, 2020
jepler
approved these changes
Jul 29, 2020
|
There's still a part of this that can't truly be tested until it's merged to main. Feel free to merge when THIS CI turns green, but keep an eye on the result of main's CI next. |
|
Upload worked (test.txt is left over from some manual testing):
|
|
Are these mpy-cross build links available publicly? |
jepler
pushed a commit
that referenced
this pull request
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpy-cross executables are uploaded to
s3://adafruit-circuit-python/bin/mpy-cross/mpy-cross*, with version tags. The version tags make the executables long but make the completely identifiable.