Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pixelbuf support iterables and floats #3260

Merged
merged 6 commits into from
Aug 17, 2020

Conversation

rhooper
Copy link

@rhooper rhooper commented Aug 10, 2020

No description provided.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One memory question and looks good otherwise. Thanks!

shared-module/_pixelbuf/PixelBuf.c Outdated Show resolved Hide resolved
tannewt
tannewt previously approved these changes Aug 13, 2020
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a merge to update things. Ok to merge after CI is happy.

@rhooper
Copy link
Author

rhooper commented Aug 15, 2020

@tannewt CI is happy.

@jepler
Copy link
Member

jepler commented Aug 16, 2020

Unfortunately there's a full flash: Build bdmicro_vina_m0 for ja took 54.75s and failed

@dhalbert
Copy link
Collaborator

Unfortunately there's a full flash: Build bdmicro_vina_m0 for ja took 54.75s and failed

I'll re-run this to see if the latest merge is better. This is a bit mysterious because the board is quite similar to other M0 Express boards.

@dhalbert
Copy link
Collaborator

Unfortunately there's a full flash: Build bdmicro_vina_m0 for ja took 54.75s and failed

I'll re-run this to see if the latest merge is better. This is a bit mysterious because the board is quite similar to other M0 Express boards.

Metro M0 Express JA fits by only 36 bytes. The vina has a few extra pins. That explains it.

The ja translation was not fitting.
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All builds fine now.

@dhalbert dhalbert merged commit 6e5c2b3 into adafruit:main Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants