Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mini sam m4 memory #3308

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Update mini sam m4 memory #3308

merged 2 commits into from
Aug 21, 2020

Conversation

bwshockley
Copy link

This pull request is for the Mini SAM M4 board. I needed to add a second type of memory to the board file.

@bwshockley
Merge pull request #2 from adafruit/master
0084f0a 
Master
@bwshockley
Update mpconfigboard.mk
135626a 
Added support for second type of memory chip.
jepler
jepler approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to merge if it passes CI. The list of commits stating that it merges our pull request #2 seems weird but the "files changed" looks as expected for the PR description.

@jepler jepler merged commit ba2db85 into adafruit:main Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwshockley @jepler