Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update busio & adafruit_bus_device docs #4928

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

2bndy5
Copy link

@2bndy5 2bndy5 commented Jun 26, 2021

resolves #4927
I also found/fixed some typos while making sure that sphinx's interlinking from busio docs works properly.

@2bndy5 2bndy5 changed the title update busio & adafruit_bus_device device docs update busio & adafruit_bus_device docs Jun 26, 2021
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @2bndy5.

@tannewt
Copy link
Member

tannewt commented Jun 28, 2021

FYI @gamblor21 for next time.

@tannewt tannewt merged commit 8a5a745 into adafruit:main Jun 28, 2021
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to make these comments; I'm a little late.

shared-bindings/busio/I2C.c Show resolved Hide resolved
shared-bindings/busio/SPI.c Show resolved Hide resolved
@dhalbert
Copy link
Collaborator

I'm suspicious that there's some odd issue, but don't worry about it for the doc purposes. You did what you had to do. I was just helping a user today who seemed to be getting the builtin module in one case and the Python module in another, depending on how the import of adafruit_bus_device was done inside several different libraries. https://forums.adafruit.com/viewtopic.php?f=60&t=180698. That may be related to the linking difficulty you saw, but I'm not sure why.

@2bndy5 2bndy5 deleted the fix-bus-device-docs branch June 28, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing blank line in adafruit_bus_device docs
4 participants